feat(Stores): Make caching and access mandatory #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
changed the title
nordfjord
approved these changes
Aug 3, 2023
bartelink
force-pushed
the
caching-mandatory
branch
from
fb4bb16
to
3795b9c
Compare
nordfjord
reviewed
Aug 3, 2023
bartelink
changed the title
rebase didn't even leave that as optional... |
bartelink
force-pushed
the
caching-mandatory
branch
from
3795b9c
to
fea3867
Compare
|
Merge it! |
bartelink
force-pushed
the
caching-mandatory
branch
from
e644368
to
7e8afa6
Compare
bartelink
commented
Aug 3, 2023
bartelink
force-pushed
the
caching-mandatory
branch
from
d517f99
to
3683562
Compare
bartelink
force-pushed
the
caching-mandatory
branch
from
3683562
to
cd89478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the value of caching is most debatable for ESDB, in general forcing people to be explicit about their caching strategy is a nudge that's too important to give up
Following the logic to its conclusion, considering the Access Strategy should also not be considered a luxury for a non-top system.
Unoptimizedcase for EventStore, EventStoreDb, MessageDb and SqlStreamStoreHT @nordfjord for driving the suggestion